Fix duplicate key exception in GetRemoteObject #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #17 Fix the issue of duplicate key exception when using `GetRemoteObject` multiple times on the same Candidate/address. * **Add `IsFrozen` method in `MsvcFrozenItemsCollection` class** - Add a method `IsFrozen` to check if an object is already frozen. - Implement the `IsFrozen` method to return true if the object is in `_frozenItemsToDestructors`. * **Modify `MakeObjectResponse` method in `MsvcDiver` class** - Check if an object is already frozen before attempting to freeze it. - Use the `IsFrozen` method from `MsvcFrozenItemsCollection` to check if an object is already frozen. - Return the already frozen object if it is found to be frozen. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/theXappy/RemoteNET/issues/17?shareId=XXXX-XXXX-XXXX-XXXX).
theXappy
pushed a commit
that referenced
this pull request
Nov 22, 2024
Fix duplicate key exception in GetRemoteObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Fix the issue of duplicate key exception when using
GetRemoteObjectmultiple times on the same Candidate/address.Add
IsFrozenmethod inMsvcFrozenItemsCollectionclassIsFrozento check if an object is already frozen.IsFrozenmethod to return true if the object is in_frozenItemsToDestructors.Modify
MakeObjectResponsemethod inMsvcDiverclassIsFrozenmethod fromMsvcFrozenItemsCollectionto check if an object is already frozen.For more details, open the Copilot Workspace session.