Remove Section mention from single/page #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for gohugo-ananke-theme-demo canceled. 🔨 Explore the source changes: 8ace5e1 🔍 Inspect the deploy log: https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/6238b772fc7121000997ade5 |
tstephen
pushed a commit
to tstephen/gohugo-theme-ananke
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
Came to my attention that the section would never be useful. Pages are most often at the root of the content directory
/content/about.md, so the section would be the homepage.If the page sits in
about/staff.mdthen the default type would beaboutand notpagethus not picking up thesingle/page.md.The current implementation will blindly print the name of the directory in which belong the page which makes it impossible to localize.
I'll remove as I doubt many user will see the difference.