-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize "By" #530
Localize "By" #530
Conversation
En/De/Es/Fr/It/Pt Fixes #528
✅ Deploy Preview for gohugo-ananke-theme-demo canceled.
|
UK: |
HU:
(no preposition)
|
Hi there It's true that I created quite a few translations in my commit a150063 when I localized the form-contact shortcode. But I used https://deepl.com for most translations including NL and RU, so unfortunately I can't help with those. |
JA: |
NO: av |
FI: Not Applicable
|
I think Turkish is a bit different than the others. "Made by {{x}}" translates to "{{x}} tarafından yapıldı". So the word is "tarafından". But the preposition comes before the verb, not the subject. |
Thanks @mivanchenko @winux1 @eddex @ssatosays @xaner4 @larihuttunen! @evrifaessa the theme omits the verb altogether by simple writing "By John Smith". Do you think there is an application in Turkish or should we just print the name alone, like in many languages it seems. |
I think printing the name alone would be a better fit. Have a nice day :) |
Thank you! Looking at this and the fact that Hugo will fallback on the english translation if not found, I don't think we have a clear way to use a word in certain language and no word in other... (Unless testing the current languages in two lists of languages etc... a route I'm not willing to take). I'm contemplating removing |
I'm fine with that. Is there a way to not have it, but for someone to add it if they wanted to? |
Not without overwriting the |
Only print a "by" for some languages Add "by" template for easy overwrite
Lots of back and forth but I chose to maintain current use, so we do have an exception on some language (to omit the print of a string). |
* Localize "By" for some languages (En/De/Es/Fr/It/Pt/No) and wrap string in a dedicated template. Fixes theNewDynamic#528
If an author is set the page will mention them with the with the "By" preposition which had never been localized. I've proceeded to add it for the languages I'm familiar with.
If you've been mentioned in the following checklist, this means I identified you as the kind person(s) who initially or most recently updated the language's localization. Would you be kind enough to add you suggestion in the comments using this simple format: EN:
By
If you have any reservations, for example the preposition needs to agree with gender or number in the given language, please let me also know in the comments.
Thank you all!
Von
By
Por
Par
Da
Por
Fixes #528