Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make disable_share settings on both page and site level #438

Closed
PengjuXu opened this issue Oct 17, 2021 · 0 comments · Fixed by #465
Closed

Make disable_share settings on both page and site level #438

PengjuXu opened this issue Oct 17, 2021 · 0 comments · Fixed by #465
Assignees
@regisphilibert

Comments

@PengjuXu
Copy link

in my site's config.toml
I have

[params]
  background_color_class = "bg-gray"
  disable_share = true
  recent_posts_number = 3

but social icons still show

gohugo-theme-ananke/layouts/partials/social-share.html

Line 5 in 869b03e

{{ if not .Params.disable_share }}

add ".Site"? to be

{{ if not .Site.Params.disable_share }}
@regisphilibert regisphilibert changed the title SNS icons Make disable_share settings on both page and site level Dec 23, 2021
regisphilibert added a commit that referenced this issue Dec 23, 2021
@regisphilibert
Make disable_share settings on both page and site level
37ead5d 
Fixes #438
@regisphilibert regisphilibert mentioned this issue Dec 23, 2021
Merged
regisphilibert added a commit that referenced this issue Dec 23, 2021
@regisphilibert
Make disable_share settings on both page and site level (#465)
57e38aa 
Fixes #438
Remicck pushed a commit to Remicck/gohugo-theme-ananke that referenced this issue Mar 7, 2022
@regisphilibert @Remicck
Make disable_share settings on both page and site level (theNewDyna…
5f13f88 
…mic#465)

Fixes theNewDynamic#438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisphilibert regisphilibert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make disable_share settings on both page and site level theNewDynamic/gohugo-theme-ananke
2 participants
@PengjuXu @regisphilibert