Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major: prune API for v1 #50

Merged
merged 2 commits into from
Oct 12, 2023
Merged

major: prune API for v1 #50

merged 2 commits into from
Oct 12, 2023

Conversation

theKashey
Copy link
Owner

@theKashey theKashey commented Oct 11, 2023 •
edited
Loading

  • raises semver to v1 to enable range bumps - Bump major version #47 47
  • almost no breaking changes
    • except pruning unused (🤞) API
    • focusMerge -> focusSolver
    • getFocusableIn -> expandFocusableNodes
    • +getFocusableNodes
    • +getTabbableNodes
    • +getRelativeFocusable

theKashey
theKashey commented Oct 11, 2023
View reviewed changes
src/index.ts Outdated
focusInside,
focusIsHidden,
setFocus,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 does not sounds right. If this is a default export fromfocus-lock package, then it should be lockFocus

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-focus-lock was importing it as moveFocusInside and such name is better indication that this is not a "persistent" lock, but only a "move inside" action.

theKashey
theKashey commented Oct 12, 2023
View reviewed changes
Copy link
Owner Author

@theKashey theKashey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 better than before

@theKashey theKashey merged commit 1fcc66f into master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theKashey