Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tcgenemycards type definition and change rarity deprecated comment to JSDoc #174

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Add missing tcgenemycards type definition and change rarity deprecated comment to JSDoc #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a77c5e
Add missing tcgenemycards to type definitions
AllySummers Sep 27, 2024
c3d968c
Change rarity regular comment to be jsdoc @deprecated
AllySummers Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion types/enums.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,16 @@ declare module "genshin-db" {
emojis = "emojis",
voiceovers = "voiceovers",

rarity = "rarity", // deprecated
/** @deprecated */
rarity = "rarity",
elements = "elements",

tcgactioncards = "tcgactioncards",
tcgcardbacks = "tcgcardbacks",
tcgcardboxes = "tcgcardboxes",
tcgcharactercards = "tcgcharactercards",
tcgdetailedrules = "tcgdetailedrules",
tcgenemycards = "tcgenemycards",
tcgkeywords = "tcgkeywords",
tcglevelrewards = "tcglevelrewards",
tcgstatuseffects = "tcgstatuseffects",
Expand Down
4 changes: 3 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,14 @@ declare module "genshin-db" {
export const constellations: QueryFunction<Constellation>;
export const crafts: QueryFunction<Craft>;
export const domains: QueryFunction<Domain>;
export const elements: QueryFunction<Element>;
export const elements: QueryFunction<Element>;
export const enemies: QueryFunction<Enemy>;
export const foods: QueryFunction<Food>;
export const geographies: QueryFunction<Geography>;
export const materials: QueryFunction<Material>;
export const namecards: QueryFunction<Namecard>;
export const outfits: QueryFunction<Outfit>;
/** @deprecated */
export const rarity: QueryFunction<Rarity>;
export const talentmaterialtypes: QueryFunction<TalentMaterial>;
export const talents: QueryFunction<Talent>;
Expand All @@ -147,6 +148,7 @@ declare module "genshin-db" {
export const tcgcardboxes: QueryFunction<TcgCardBoxes>;
export const tcgcharactercards: QueryFunction<TcgCharacterCards>;
export const tcgdetailedrules: QueryFunction<TcgDetailedRules>;
export const tcgenemycards: QueryFunction<TcgEnemyCards>;
export const tcgkeywords: QueryFunction<TcgKeywords>;
export const tcglevelrewards: QueryFunction<TcgLevelRewards>;
export const tcgstatuseffects: QueryFunction<TcgStatusEffects>;
Expand Down