Skip to content

Commit

Permalink
use mysql-replication<0.26 as new versions crash when receiving queries
Browse files Browse the repository at this point in the history 
with encoding utf8mb4.
TODO - file a bug report
  • Loading branch information
@the4thdoctor
the4thdoctor committed Feb 11, 2022
1 parent 08b906f commit 38c7a90
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def readme():
],
install_requires=[
'PyMySQL>=0.10.0',
'mysql-replication>=0.22',
'mysql-replication<0.27',
'psycopg2-binary>=2.8.3',
'PyYAML>=3.13',
'tabulate>=0.8.1',
Expand Down

6 comments on commit 38c7a90

@dongwook-chan
Copy link

@dongwook-chan dongwook-chan commented on 38c7a90 Mar 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the4thdoctor
I'm terribly sorry.
I think my commit submitted to mysql-replication has cause the crash.
Kvitek, user of pg_chameleon was kind to report an issue caused by mysql-replication 0.27.
Could you please share the detail of the crash?
It would be helpful for me to come up with some solutions.

@the4thdoctor
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I was planning to submit a bug report.
I was caught in some other stuff that distracted me.
I'll grab some debug and I'll share here.
Thanks!

@the4thdoctor
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've opened a ticket as the issue is still present in version 0.30.
You can find the details and how to reproduce it here .
TA!

@dongwook-chan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the4thdoctor
I'll take time to look at this issue.
Sorry for the inconvenience.

@dongwook-chan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the4thdoctor
I have made some updates to python-mysql-replication and confirmed that it is no longer possible to reproduce the issue.
I've create a PR about it and I'll let you know as soon as it is released.

@the4thdoctor
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing news!
I'll make a new release as soon as the new library becomes available.
Ta!

Please sign in to comment.