Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #441

Merged
merged 3 commits into from
Nov 12, 2024
Merged

chore: fix typo #441

merged 3 commits into from
Nov 12, 2024

Conversation

phi16
Copy link
Contributor

@phi16 phi16 commented Nov 12, 2024

Description

fix typo: x and y swapped.

  x --refl--> x
  |           :
p |   filler  : p∙q
  v           v
  y ----q---> z

@Lavenza
Copy link
Member

Lavenza commented Nov 12, 2024

Pull request preview

plt-amy
plt-amy previously approved these changes Nov 12, 2024
@plt-amy plt-amy enabled auto-merge (squash) November 12, 2024 13:36
@phi16
Copy link
Contributor Author

phi16 commented Nov 12, 2024

Oh sorry, I've just found another issue in my modification... so could I push additional fixes? Much sorry...

  • i and j should also be swapped (for the former diagram)
  • the arrows should be swapped, instead of the types, to match the other filler diagrams (for the latter diagram)

auto-merge was automatically disabled November 12, 2024 13:53

Head branch was pushed to by a user without write access

@plt-amy
Copy link
Member

plt-amy commented Nov 12, 2024

@phi16 no worries, and thanks for the fixes 🙂

@ncfavier ncfavier merged commit 2e1684b into the1lab:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants