Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1060, etc #1117

Merged
merged 2 commits into from
Oct 29, 2020
Merged

fix #1060, etc #1117

merged 2 commits into from
Oct 29, 2020

Conversation

LonelySteve
Copy link
Contributor

@LonelySteve LonelySteve commented Oct 28, 2020

@LonelySteve LonelySteve changed the title fix #1060 fix #1060, etc Oct 29, 2020
@Geeyun-JY3
Copy link

可算是看到我在 #731 (comment) 提的了😄

@the1812
Copy link
Owner

the1812 commented Oct 29, 2020

好家伙 我还以为 #731 那个互动视频早就做进去了(

@LonelySteve
Copy link
Contributor Author

好家伙 我还以为 #731 那个互动视频早就做进去了(

其实我有点好奇,这个夜间模式的样式分这么多份文件,有什么规定吗?我把这段代码放在 dark-slice-1.css 里合不合适?

@the1812
Copy link
Owner

the1812 commented Oct 29, 2020

其实我有点好奇,这个夜间模式的样式分这么多份文件,有什么规定吗?我把这段代码放在 dark-slice-1.css 里合不合适?

每个文件 1000 行左右, 不然打开一个文件就很卡, 一般往数字大的里放就行, 目前是 dark-slice-13.scss

等会我也会更新下 CONTRIBUTING.md 里的文档的

@LonelySteve
Copy link
Contributor Author

其实我有点好奇,这个夜间模式的样式分这么多份文件,有什么规定吗?我把这段代码放在 dark-slice-1.css 里合不合适?

每个文件 1000 行左右, 不然打开一个文件就很卡, 一般往数字大的里放就行, 目前是 dark-slice-13.scss

等会我也会更新下 CONTRIBUTING.md 里的文档的

嗯,我明白了,待会我会修改一下的

@Geeyun-JY3
Copy link

好家伙 我还以为 #731 那个互动视频早就做进去了(

怪我偷懒把当天发现的写一起了😂,混在一起很容易就看漏眼了,应该独立出来。

@the1812 the1812 merged commit 4fb5144 into the1812:preview Oct 29, 2020
the1812 added a commit that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants