Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychron Q1 Revision Renames #2354

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

adophoxia
Copy link
Contributor

Description

Rename Q1 revision names to common naming and restructured to be in their own respective folders. (Ex: q1/v2 and q1/v1)

QMK Pull Request

#1736

VIA Keymap Pull Request

#1736

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot Cipulot merged commit b98412f into the-via:master Oct 24, 2024
2 checks passed
@adophoxia adophoxia deleted the keychron-q1-rename branch October 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants