Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for era/divine #1971

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Add support for era/divine #1971

merged 2 commits into from
Jul 29, 2023

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Jul 28, 2023 •
edited
Loading

Description

Add support for era/divine

QMK Pull Request

qmk/qmk_firmware#21593

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@eerraa
Add support for era/divine
ad36cc5 
Add support for era/divine
@Xelus22
Copy link
Collaborator

Xelus22 commented Jul 29, 2023

Please paste in QMK PR

@eerraa
Copy link
Contributor Author

eerraa commented Jul 29, 2023

Please paste in QMK PR

Thank you sir, I forgot about it for a while.

Xelus22
Xelus22 requested changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove v2 definition (src/ folder) as that is only for legacy boards. Everything else looks good.

@eerraa
Delete src/divine
684f5a1 
Delete src/divine
@eerraa
Copy link
Contributor Author

eerraa commented Jul 29, 2023

Please remove v2 definition (src/ folder) as that is only for legacy boards. Everything else looks good.

@Xelus22 Thank you., I've done as you requested.

@Xelus22 Xelus22 merged commit 916829f into the-via:master Jul 29, 2023
2 checks passed
@eerraa
Copy link
Contributor Author

eerraa commented Aug 18, 2023

@Xelus22
Hi there,
I'm using both Vial and Via.
If the board's v2 definition is missing, newer Vial-based firmware will throw a "fetching v2 definition failed" error and VIA will not work.
Could you please allow me to merge the v2 definition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerraa @Xelus22