Add mokey12x2 #1907
Closed
Add mokey12x2 #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mokey12x2
Xelus22
requested changes
Jun 18, 2023
Comment on lines
+6
to
+63
| "keycodes": ["qmk_lighting"], | ||
| "menus": [ | ||
| { | ||
| "label": "Lighting", | ||
| "content": [ | ||
| { | ||
| "label": "Backlight", | ||
| "content": [ | ||
| { | ||
| "label": "Brightness", | ||
| "type": "range", | ||
| "options": [0, 200], | ||
| "content": ["id_qmk_rgb_matrix_brightness", 3, 1] | ||
| }, | ||
| { | ||
| "label": "Effect", | ||
| "type": "dropdown", | ||
| "content": ["id_qmk_rgb_matrix_effect", 3, 2], | ||
| "options": [ | ||
| ["All Off", 0], | ||
| ["SOLID_COLOR", 1], | ||
| ["BREATHING", 2], | ||
| ["CYCLE_ALL", 3], | ||
| ["CYCLE_LEFT_RIGHT", 4], | ||
| ["CYCLE_UP_DOWN", 5], | ||
| ["RAINBOW_MOVING_CHEVRON", 6], | ||
| ["CYCLE_OUT_IN", 7], | ||
| ["CYCLE_OUT_IN_DUAL", 8], | ||
| ["CYCLE_PINWHEEL", 9], | ||
| ["CYCKE_SPIRAL", 10], | ||
| ["DUAL_BEACON", 11], | ||
| ["RAINBOW_BEACON", 12], | ||
| ["RAINDROPS", 13], | ||
| ["TYPING_HEATMAP", 14], | ||
| ["SOLID_REACTIVE_SIMPLE", 15], | ||
| ["SOLID_REACTIVE", 16], | ||
| ["SOLID_REACTIVE_CROSS", 17], | ||
| ["MATRIX_MULTISPLASH", 18] | ||
| ] | ||
| }, | ||
| { | ||
| "showIf": "{id_qmk_rgb_matrix_effect} != 0", | ||
| "label": "Effect Speed", | ||
| "type": "range", | ||
| "options": [0, 255], | ||
| "content": ["id_qmk_rgb_matrix_effect_speed", 3, 3] | ||
| }, | ||
| { | ||
| "showIf": "{id_qmk_rgb_matrix_effect} != 0", | ||
| "label": "Color", | ||
| "type": "color", | ||
| "content": ["id_qmk_rgb_matrix_color", 3, 4] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], |
There was a problem hiding this comment.
Doesn't look like you have RGB enabled in QMK at all?
There was a problem hiding this comment.
Yes, QMK has not added RGB function, I am going to modify it, can you pass the review of VIA first
There was a problem hiding this comment.
No either remove it for now and then add it back in later when you update QMK, or add it to QMK first. Otherwise your users will have errors all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mokey12x2
QMK Pull Request
qmk/qmk_firmware#20702
Checklist
0xFEED