Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add creek70 #1774

Merged
merged 4 commits into from
Mar 24, 2023
Merged

add creek70 #1774

merged 4 commits into from
Mar 24, 2023

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Mar 20, 2023

Description

QMK Pull Request

qmk/qmk_firmware#19789

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the correct colours on the alpha and modifier keys.
https://www.caniusevia.com/docs/layouts#kle-json-rules

@spbgzh
Copy link
Contributor Author

spbgzh commented Mar 22, 2023

@Xelus22
CleanShot 2023-03-22 at 18 20 53@2x
Is this one ok?

@Xelus22 Xelus22 merged commit 091cda3 into the-via:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spbgzh @Xelus22