Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add h87 g2 to via #1756

Merged
merged 3 commits into from
Apr 10, 2023
Merged

add h87 g2 to via #1756

merged 3 commits into from
Apr 10, 2023

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented Mar 14, 2023 •
edited
Loading

Description

Add V3-supported files for h87 gen 2 PCB

QMK Pull Request

](qmk/qmk_firmware#20053)

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba
Copy link
Contributor

wilba commented Mar 14, 2023

https://media.tenor.com/gaEpIfzxzPEAAAAC/pedro-monkey-puppet.gif

@hineybush hineybush closed this Mar 14, 2023
@hineybush hineybush reopened this Mar 14, 2023
@hineybush
Copy link
Contributor Author

am stupid

Xelus22
Xelus22 requested changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you put in the wrong VID hiney. With your usual one being 0x04D8

@hineybush
Copy link
Contributor Author

Looks like you put in the wrong VID hiney. With your usual one being 0x04D8

that's the Microchip VID for my 32u4 based boards, I'm using an arbitrary one for my STM32 boards. Turned out the first one I used was the same as another board.

@Xelus22 Xelus22 merged commit f9125e5 into the-via:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hineybush @wilba @Xelus22