-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding jabberwocky v2 keyboard #1647
Conversation
Should probably change product ids. Going to address this |
Updated productId QMK PR here: qmk/qmk_firmware#19611 |
please ping once the merge of qmk has been done. |
@yiancar QMK PR merged |
Hello you have added V1 and V2 here. they both have the same PID/VID, this is not allowed. I presume there is a different firmware in V1 and V2? |
The firmware for v1 and v2 is different. I explicitly changed the pid for v2 so now each version has a unique pid. This is the change merged in the most recent QMK PR. |
Ok I see, however in the V1 and V2 JSONS on this PR, both have
|
In this PR, I added v1 and v2 folders. These are the productIds for each version as seen in this PR: From what I can see, the v1 and v2 productIds are correct. The v1 json already existed so the only change in this PR is a file path change for v1. v2 has the new productId, different from v1. |
sorry I am blind.... I couldnt see the right diff.... cheers and thanks for clarifying |
Description
Adding jabberwocky v2 .json
Reorganizing /jabberwocky/ directory, since v1 already is ported to via
QMK Pull Request
qmk/qmk_firmware#19014
Update to productId PR open here: qmk/qmk_firmware#19611
Checklist
0xFEED