Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact composer plugin v1.0.1 #1473

Merged

Conversation

SergeyMosin
Copy link

  • fix: use compact template in non-destructive way (do not replace the PopupsCompose template if a different wysiwyg is used)
  • improve: add dark theme support and use 'button' element as menu trigger for consistent styling
  • improve: fire the 'squire2-toolbar' event after more props are added

As of now the CompactComposer needs to be manually activated here:

like so:

'editorWysiwyg' => 'CompactComposer', 

@the-djmaze
Copy link
Owner

the-djmaze commented Mar 1, 2024

As of now the CompactComposer needs to be manually activated here:

Not really. See settings screenshot at #1470 (comment)

@the-djmaze the-djmaze merged commit 380eae6 into the-djmaze:master Mar 1, 2024
1 check passed
@the-djmaze the-djmaze added enhancement New feature or request extensions (plugin) labels Mar 1, 2024
@SergeyMosin
Copy link
Author

As of now the CompactComposer needs to be manually activated here:

Not really. See settings screenshot at #1470 (comment)

I see, I was a bit confused by this TODO here:

// TODO: make 'which' user configurable
const which = SettingsUserStore.editorWysiwyg(),
wysiwyg = WYSIWYGS.find(item => which == item.name) || WYSIWYGS.find(item => 'Squire' == item.name);
// const wysiwyg = WYSIWYGS.find(item => 'Squire' == item.name);

the-djmaze pushed a commit that referenced this pull request Mar 4, 2024
@the-djmaze
Copy link
Owner

Removed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants