Added function for ldap-identities plugin to filter by mail prefixes (allow compatibility for e.g. Exchange and others) #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mail prefix is needed to filter mailidentities. For example suche set by Exchange in the ProxyAddresses field, which can hold different address types
Added function (and additional code to start it) that helps to clean up the mail addresses array. It removes the prefix (if set in config) and removes all addresses with no or a different prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: Exchange saves the mail identities in the ldap attribut "proxyAddresses". This attribut is not only used for mail addresses, but also for SIP, X400 and others (every program can add addresses here with a custom prefix ... or no prefix).
Exchange for example saves the addresses with "smtp:" as prefix e.g. "smtp:[email protected]".
If ldap-identities plugin greps the addresses from the proxyAddresses attribut, it gets all addresses listed there (with prefixes), not only the mail addresses. These identities can't be used to sent mail.
The solution: This solution adds a new entry to the config and a function to cleanup the addresses: If a prefix is set in the config, it removes all addresses without the prefix from the search result (not from the ldap attribut ;) ) and then removes the prefix from the remaining addresses. This way you have only clean mail addresses as identities.