Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snappymail] Improve Redis support #116

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

Alphix
Copy link

@Alphix Alphix commented Aug 21, 2021

By using a connection URL, it is possible to support all Predis features, like
passwords, unix sockets, database selection, etc.

Tested with TCP and unix socket connections.

Closes #113

Alphix added 2 commits August 21, 2021 13:32
By using a connection URL, it is possible to support all Predis features, like
passwords, unix sockets, database selection, etc.

Tested with TCP and unix socket connections.

Closes the-djmaze#113
The "redis" scheme is undocumented and has a slightly different syntax, so
prefer the "tcp" scheme.
@the-djmaze the-djmaze merged commit 4a39093 into the-djmaze:master Aug 23, 2021
@the-djmaze
Copy link
Owner

the-djmaze commented Aug 23, 2021

Although i merged this PR. i'm reverting your changes for compatibility.
The real bug was only in MailSo\Cache\Drivers\Redis class.

Trick will now become:
fast_cache_redis_host = 'tcp://127.0.0.1:6379'
fast_cache_redis_port = 0

I also made this change to Memcache driver.

the-djmaze pushed a commit that referenced this pull request Aug 23, 2021
@Alphix Alphix deleted the improve_redis_support branch August 23, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Redis configuration
2 participants