Border fixes #115
Merged
Border fixes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting an earlier PR that got closed when I renamed my branch.
To address some of the border inconsistencies, I tweaked the borders where the below countries adjoin one another.
Egypt/Israel/Jordan/Lebanon/Palestine/Saudi Arabia/Syria (#99 and #100)
Before:
After:
Namibia/Zimbabwe (#98)
Before:
After:
Singapore/Malaysia
There is no real meaningful distance between these two countries as only a narrow (~500m) strait/channel separates them.
Before:
After:
Reduce file size
As I was editing, I noticed how most of the coordinate values had up 15 decimal places. This is hugely overkill when you're dealing in 1km increments, and adds over 100k to the file size. I trimmed these values to 6 decimal places max and put it in a separate commit so you can more easily see the meaningful changes (above) and revert separately if needed.