Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small accessibility issue #13

Open
ecxmwo opened this issue Jan 9, 2019 · 2 comments
Open

small accessibility issue #13

ecxmwo opened this issue Jan 9, 2019 · 2 comments

Comments

@ecxmwo
Copy link

ecxmwo commented Jan 9, 2019

Hi,

your plugin was the only one which I found is lightweight, uses a real element and is nearly fully accessible. One accessibility issue I noticed when testing with NVDA screenreader is that the focused option is not read in screenreader. Only after you click on it or choose it with ENTER. This you can very easily solve. Just insert $dropdown.attr('aria-activedescendant', $li.attr('id')); in toggleHover() and give $dropdown as reference. This is what the aria-activedescendant is meant for (https://www.w3.org/WAI/GL/wiki/Using_aria-activedescendant_to_allow_changes_in_focus_within_widgets_to_be_communicated_to_Assistive_Technology) And be sure to reset the activedescendent in resetDropdown() - e.g. if ESC was pressed and the focused entry was not chosen: $dropdown.attr('aria-activedescendant', $dropdown.children('.selected').attr('id')); otherwise the currently selected entry will not be read correctly by the screenreader.

@thdoan
Copy link
Owner

thdoan commented Jan 18, 2019

Thanks for the report and fix. Would it be possible for you to do a PR?

@thdoan
Copy link
Owner

thdoan commented Jun 9, 2019

@ecxmwo This has been fixed in v4.15.0. Please update plugin and close if verified. Thanks for reporting this.

thdoan added a commit that referenced this issue Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants