Manual LGIrrep{3} additions for missing k-points in Φ-Ω
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix test-suite to account for fact that parsed ISOTROPY may now contain fewer little group irreps (fewer k-points) than returned by `get_lgirreps` - remove `@test_broken` from `test/bandreps.jl` (fixed now!) - minor fix to `check_multtable_vs_ir`
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 69.15% 69.18% +0.03%
==========================================
Files 18 18
Lines 2240 2239 -1
==========================================
Hits 1549 1549
+ Misses 691 690 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the little groups and little group irreps that are referenced by
bandreps(usually withallpaths = true) relative to what is returned byget_lgirreps(i.e. what is included in ISOTROPY). Previously, there were 145 missing irreps, all irreps belonging to the representation domain Φ but not in the basic domain Ω.Here, we have manually added these 145 irreps by comparing with Bilbao's listings. This removes all the
@test_brokencases fromtest/bandreps.jl.