*: replace golang.org/x/exp with standard library
#8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These experimental packages are now available in the Go standard library. Since we upgraded our minimum Go version to 1.23 in PR #7796, we can replace them with the standard library: 1. golang.org/x/exp/slices -> slices [1] 2. golang.org/x/exp/maps -> maps [2] 3. golang.org/x/exp/rand -> math/rand/v2 [3] [1]: https://go.dev/doc/go1.21#slices [2]: https://go.dev/doc/go1.21#maps [3]: https://go.dev/doc/go1.22#math_rand_v2 Signed-off-by: Eng Zer Jun <[email protected]>
Two sections in total: one for direct dependencies, and one for indirect dependencies. Reference: golang/go#56471 Signed-off-by: Eng Zer Jun <[email protected]>
Juneezee
commented
Dec 23, 2024
There was a problem hiding this comment.
This PR also properly tidies up the go.mod file. There is a known issue where go mod tidy does not join multiple require sections into just two sections (direct and indirect), as described here: golang/go#56471.
fpetkovski
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These experimental packages are now available in the Go standard library. Since we upgraded our minimum Go version to 1.23 in PR #7796, we can replace them with the standard library:
golang.org/x/exp/slices->slices(https://go.dev/doc/go1.21#slices)golang.org/x/exp/maps->maps(https://go.dev/doc/go1.21#maps)golang.org/x/exp/rand->math/rand/v2(https://go.dev/doc/go1.22#math_rand_v2)Verification