Sidecar: use prometheus metrics for min timestamp #7820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar
branch
from
51c58f7
to
6cff6e2
Compare
pedro-stanaka
approved these changes
Oct 14, 2024
GiedriusS
reviewed
Oct 14, 2024
It doesn't have this data for whole tsdb. Only for head |
GiedriusS
reviewed
Oct 14, 2024
Read "minT" from prometheus metrics so that we also set it for sidecars that are not uploading blocks. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar
branch
from
6cff6e2
to
c4d1de9
Compare
GiedriusS
approved these changes
Oct 23, 2024
GiedriusS
deleted the
mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sidecar read "minT" from prometheus metrics instead of the shipper. This has the benefit that it also works for sidecar deployments that do not upload blocks, so that they can be pruned by time range too.