receive: randomize TSDB compaction start times #7795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
randomize_compaction
branch
4 times, most recently
from
47cc1ee
to
edca98c
Compare
GiedriusS
force-pushed
the
randomize_compaction
branch
from
edca98c
to
75872aa
Compare
Don't compact all TSDBs at the same time because that leads to latency spikes. Add initial randomized latency (between 0 and 60 seconds) to spread out the load over time. Signed-off-by: Giedrius Statkevičius <[email protected]>
|
Will this maintain the same block ranges regardless of when we do the compaction? Meaning we won't have blocks that are shifted in time or longer than the configured block size? |
GiedriusS
force-pushed
the
randomize_compaction
branch
from
75872aa
to
a9f9a69
Compare
GiedriusS
changed the title
|
Yeah, compaction always takes the head's mint and starts from there: https://github.com/prometheus/prometheus/blob/main/tsdb/db.go#L1278-L1279 But while digging into this, I've spotted that a new Prometheus version has a compaction delay option: https://github.com/prometheus/prometheus/blob/main/tsdb/db.go#L89 |
|
Closing this in favor of Prometheus dependency bump + enabling that option 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't compact all TSDBs at the same time because that leads to latency spikes. Add initial randomized latency (between 0 and 60 seconds) to spread out the load over time.