Proxy: fix response set panic #7484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffm-fix-response-set-panic
branch
from
8bc5b03
to
a356afd
Compare
|
CC @wallee94 |
fpetkovski
approved these changes
Jun 25, 2024
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Michael Hoffmann <[email protected]>
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Michael Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding the error tag panics in my prod with a nil pointer dereference. We can reach this if the error we face is not a context exceeded error but the timer has expired. I think we also forgot to receive from the timer channel in the lazy response set.
Verification
Existing tests.