Put query stats logging under s.debugLogging #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
fpetkovski
approved these changes
Jun 19, 2024
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The log line being changed in the PR uses
fmt.Sprintf("%+v", stats)which is quite expensive and show up in our CPU profile.We never enable debug level logging but it still evaluates
fmt.Sprintf.Put the log line under
debugLogging. I think this makes no difference for Thanos users because when log level is set todebug, Store Gateway will setdebugLoggingto true as well.Verification