-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency - Update minio-go to v7.0.70 #7335
Conversation
efd7c0e
to
bc19a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
However, I think it is still unclear to me how to use the EKS Pod Identity feature. Do we need to update docs somewhere for instructions?
IMO it's more on AWS side; the docs are available on their side and well explained how it works or how to use Pod Identity feature instead of IAM Roles for service accounts (IRSA) in EKS. in case of Thanos IIUC based on the s3 pkg and your comment we are relying on Minio-go, hence they had to push the update first to support it;
I did a quick search in the docs, and maybe we can add it here, wdyt? |
Cool, thanks for the comment. I think I am ok to proceed with this pr without updating docs. We don't have doc for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There is a conflict in changelog |
Add support for EKS Pod Identity fix issue: thanos-io#7157 Signed-off-by: farhad <[email protected]>
Updated changelog Signed-off-by: farhad <[email protected]>
I just rebased my branch so it should be fine now |
* Update minio-go to v7.0.70 Add support for EKS Pod Identity fix issue: thanos-io#7157 Signed-off-by: farhad <[email protected]> * Changelog - support for EKS Pod Identity Updated changelog Signed-off-by: farhad <[email protected]> --------- Signed-off-by: farhad <[email protected]> Signed-off-by: mluffman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the changelog entry seems wrong. It shouldn't be under Fixed
. Should be Added
instead as it is a feature/enhancement.
I've opened a new PR to fix the changelog position; |
* Update minio-go to v7.0.70 Add support for EKS Pod Identity fix issue: thanos-io#7157 Signed-off-by: farhad <[email protected]> * Changelog - support for EKS Pod Identity Updated changelog Signed-off-by: farhad <[email protected]> --------- Signed-off-by: farhad <[email protected]>
* Update minio-go to v7.0.70 Add support for EKS Pod Identity fix issue: thanos-io#7157 Signed-off-by: farhad <[email protected]> * Changelog - support for EKS Pod Identity Updated changelog Signed-off-by: farhad <[email protected]> --------- Signed-off-by: farhad <[email protected]>
fix issue: #7157
Bumping the Minio-go dependency version to the v7.0.70 as it contains support for EKS Pod Identity
Changes
Bump the minio-go version to v7.0.70