Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warnings in query frontend #7289

Merged
merged 4 commits into from
Apr 23, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix failing tests
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
  • Loading branch information
fpetkovski committed Apr 19, 2024

Verified

This commit was signed with the committer’s verified signature.
fpetkovski Filip Petkovski
commit 59f6a648fc67872cded8d637ff7e70d2353d9f5e
7 changes: 5 additions & 2 deletions internal/cortex/querier/queryrange/results_cache.go
Original file line number Diff line number Diff line change
@@ -99,7 +99,8 @@ func (PrometheusResponseExtractor) Extract(start, end int64, from Response) Resp
Stats: extractStats(start, end, promRes.Data.Stats),
Analysis: promRes.Data.Analysis,
},
Headers: promRes.Headers,
Headers: promRes.Headers,
Warnings: promRes.Warnings,
}
}

@@ -115,6 +116,7 @@ func (PrometheusResponseExtractor) ResponseWithoutHeaders(resp Response) Respons
Stats: promRes.Data.Stats,
Analysis: promRes.Data.Analysis,
},
Warnings: promRes.Warnings,
}
}

@@ -128,7 +130,8 @@ func (PrometheusResponseExtractor) ResponseWithoutStats(resp Response) Response
Result: promRes.Data.Result,
Analysis: promRes.Data.Analysis,
},
Headers: promRes.Headers,
Headers: promRes.Headers,
Warnings: promRes.Warnings,
}
}

1 change: 1 addition & 0 deletions internal/cortex/querier/queryrange/results_cache_test.go
Original file line number Diff line number Diff line change
@@ -91,6 +91,7 @@ var (
},
},
},
Warnings: []string{"test-warn"},
}
parsedHistogramResponse = &PrometheusResponse{
Status: "success",
Loading