Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't halt compaction due to overlapping sources when vertical compac… #7225

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Don't halt compaction due to overlapping sources when vertical compac… #7225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/compact/compact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,14 +807,17 @@ type CompactionLifecycleCallback interface {
type DefaultCompactionLifecycleCallback struct {
}

func (c DefaultCompactionLifecycleCallback) PreCompactionCallback(_ context.Context, _ log.Logger, _ *Group, toCompactBlocks []*metadata.Meta) error {
func (c DefaultCompactionLifecycleCallback) PreCompactionCallback(_ context.Context, logger log.Logger, cg *Group, toCompactBlocks []*metadata.Meta) error {
// Due to #183 we verify that none of the blocks in the plan have overlapping sources.
// This is one potential source of how we could end up with duplicated chunks.
uniqueSources := map[ulid.ULID]struct{}{}
for _, m := range toCompactBlocks {
for _, s := range m.Compaction.Sources {
if _, ok := uniqueSources[s]; ok {
return halt(errors.Errorf("overlapping sources detected for plan %v", toCompactBlocks))
if !cg.enableVerticalCompaction {
return halt(errors.Errorf("overlapping sources detected for plan %v", toCompactBlocks))
}
level.Warn(logger).Log("msg", "overlapping sources detected for plan", "duplicated_block", s, "to_compact_blocks", fmt.Sprintf("%v", toCompactBlocks))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think it is needed to add a counter metric for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to have it for debugging later.

Copy link
Contributor Author

@yeya24 yeya24 Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the log which contains the information of duplicated source. I feel it is already more useful than the counter metric.
Can we skip the metric until we see user asks for it. WDYT? @saswatamcode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! Sure let's skip then.

}
uniqueSources[s] = struct{}{}
}
Expand Down
Loading