e2e: fix compactor test #6896
Merged
e2e: fix compactor test #6896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted some randomness in the compactor test - `thanos_blocks_meta_synced` includes cached blocks. Depending on luck, Store might or might not see those blocks leading to inconsistent results. Thus, only check the loaded metas count because that's what matters. Signed-off-by: Giedrius Statkevičius <[email protected]>
saswatamcode
approved these changes
Nov 15, 2023
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
Spotted some randomness in the compactor test - `thanos_blocks_meta_synced` includes cached blocks. Depending on luck, Store might or might not see those blocks leading to inconsistent results. Thus, only check the loaded metas count because that's what matters. Signed-off-by: Giedrius Statkevičius <[email protected]>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
Spotted some randomness in the compactor test - `thanos_blocks_meta_synced` includes cached blocks. Depending on luck, Store might or might not see those blocks leading to inconsistent results. Thus, only check the loaded metas count because that's what matters. Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted some randomness in the compactor test -
thanos_blocks_meta_syncedincludes cached blocks. Depending on luck, Store might or might not see those blocks leading to inconsistent results. Thus, only check the loaded metas count because that's what matters.