store: fix stringlabel build errors for prometheus store api #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <[email protected]>
fpetkovski
approved these changes
Oct 30, 2023
yeya24
reviewed
Oct 30, 2023
| finalLbls := labelpb.ExtendSortedLabels(seriesLbls, externalLbls) | ||
| finalLbls = append(finalLbls, dedup.PushdownMarker) | ||
| b.Add(dedup.PushdownMarker.Name, dedup.PushdownMarker.Value) | ||
| b.Sort() |
There was a problem hiding this comment.
Do we need this manual sort for the builder? Thought it is sorted.
There was a problem hiding this comment.
Builder is sorted, Scratchbuilder is not!
yeya24
approved these changes
Oct 31, 2023
rabenhorst
pushed a commit
to rabenhorst/thanos
that referenced
this pull request
Nov 15, 2023
…io#6861) Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Sebastian Rabenhorst <[email protected]>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
…io#6861) Signed-off-by: Michael Hoffmann <[email protected]>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
…io#6861) Signed-off-by: Michael Hoffmann <[email protected]>
fpetkovski
pushed a commit
to fpetkovski/thanos
that referenced
this pull request
Oct 31, 2024
…io#6861) Signed-off-by: Michael Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification