Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e/store: fix flaky limits test #6193

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

GiedriusS
Copy link
Member

Intentionally disable the default in-memory cache to get consistent values during the test.

I have identified this originally in #5906. Since that PR is stuck a bit now, I've moved out the fix into this PR.

@GiedriusS GiedriusS marked this pull request as ready for review March 8, 2023 09:42
Intentionally disable the default in-memory cache to get consistent
values during the test.

Signed-off-by: Giedrius Statkevičius <[email protected]>
@GiedriusS GiedriusS force-pushed the store_flaky_limits_test branch from 595e30a to de1fab7 Compare March 8, 2023 09:50
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Would prevent red CI quite a bit! 🎉

@GiedriusS GiedriusS merged commit 3dea8cf into thanos-io:main Mar 8, 2023
@GiedriusS GiedriusS deleted the store_flaky_limits_test branch March 8, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants