Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: fix multitsdb flush with one sample in head #6183

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Mar 4, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixed off-by-one in the receive/multitsdb flush method.

Verification

Added a unittest that fails without the change but passes with.

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-one-sample-flush-should-produce-a-block branch from 08d60c8 to 54fc7dc Compare March 4, 2023 18:03
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-one-sample-flush-should-produce-a-block branch from 54fc7dc to 3b0d5ea Compare March 4, 2023 18:05
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@GiedriusS GiedriusS merged commit 1627c76 into thanos-io:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants