cacheutil: upgrade rueidis to 0.0.93 to fix https://github.com/rueian/rueidis/pull/170 #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
upgrade-rueidis-0.0.93
branch
2 times, most recently
from
a548546 to
f0bcf69
Compare
rueian
force-pushed
the
upgrade-rueidis-0.0.93
branch
2 times, most recently
from
3adf9c4 to
782ef5c
Compare
douglascamata
approved these changes
Feb 2, 2023
douglascamata
suggested changes
Feb 2, 2023
yeya24
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Yeah as mentioned by @douglascamata let's have a changelog entry! Otherwise LGTM.
rueian
force-pushed
the
upgrade-rueidis-0.0.93
branch
from
782ef5c to
99bb689
Compare
…he client-side caching is disabled. redis/rueidis#170 Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
upgrade-rueidis-0.0.93
branch
from
99bb689 to
0121edc
Compare
|
Thanks @douglascamata, @yeya24! I have updated the CHANGELOG.md. |
yeya24
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @GiedriusS, @douglascamata, @yeya24,
A user reported a panic bug when using Thanos v0.30.1 with an old Redis here redis/rueidis#55 (comment).
The bug is only possible to be triggered when the client-side caching is disabled and the first request to a Redis connection is timed out. So, if the client-side caching is enabled, then the bug will not be triggered.
A fix has been addressed in redis/rueidis#170 and this PR upgrades rueidis to v0.0.93 to apply it.