Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing store to match debug level #5981

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

kama910
Copy link
Contributor

@kama910 kama910 commented Dec 20, 2022

Signed-off-by: Kama Huang [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5825

Verification

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this makes sense. The error is anyway propagated to the user in the UI and there is also an alert in the ruler mixin for this.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 98f6b22 into thanos-io:main Dec 20, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive: very verbose logging
3 participants