Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: Fix sampler defaults #5887

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Tracing: Fix sampler defaults #5887

merged 3 commits into from
Nov 15, 2022

Conversation

matej-g
Copy link
Collaborator

@matej-g matej-g commented Nov 10, 2022

Signed-off-by: Matej Gera [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5872

  • Makes sure we use rate limiting sampler as default, as was the case pre-migration
  • Correct the of parent-based sampler and option - we should always use parent based sampler to respect the span parent, if it is being sampled. Optionally let user configure parent based sampler.

Verification

  • Added unit test

@matej-g matej-g mentioned this pull request Nov 10, 2022
Closed
@matej-g
Copy link
Collaborator Author

matej-g commented Nov 10, 2022

cc @metonymic-smokey

yeya24
yeya24 previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

yeya24
yeya24 reviewed Nov 12, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we get this into the release branch and then merge back to main?

@matej-g
Copy link
Collaborator Author

matej-g commented Nov 14, 2022

@yeya24, yes, that's probably better idea if we want a patch release. I'll point it to release 29 branch then.

@matej-g matej-g force-pushed the fix-sampler-defaults branch from 6e89d4b to 7980c2e Compare November 14, 2022 21:20
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2022
@matej-g matej-g changed the base branch from main to release-0.29 November 14, 2022 21:21
@matej-g
Fix sampler defaults
10ef0d1 
Signed-off-by: Matej Gera <[email protected]>
@matej-g
Add CHANGELOG
d142ac7 
Signed-off-by: Matej Gera <[email protected]>
@matej-g matej-g force-pushed the fix-sampler-defaults branch from 7980c2e to d142ac7 Compare November 14, 2022 21:24
yeya24
yeya24 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One question only.

.circleci/config.yml
@@ -3,6 +3,7 @@ version: 2.1

orbs:
go: circleci/[email protected]
git-shallow-clone: guitarrapc/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to add this btw? @matej-g

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI was failing because of https://cloud-native.slack.com/archives/CL25937SP/p1666777294865379, it's just a cherry-pick from the main but should not affect the release itself.

@yeya24 yeya24 merged commit df047ef into thanos-io:release-0.29 Nov 15, 2022
@matej-g matej-g mentioned this pull request Jan 10, 2023
Closed
GiedriusS pushed a commit that referenced this pull request Jan 12, 2023
@matej-g @GiedriusS
Tracing: Fix sampler defaults (#5887)
95256a7 
* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS added a commit that referenced this pull request Jan 17, 2023
@GiedriusS
Tracing: Fix sampler defaults (#5887)
27c0d37 
* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
saswatamcode pushed a commit that referenced this pull request Jan 18, 2023
@GiedriusS @clwluvw @kama910
Merge release 0.30 into main (#6041)
5714506 
* compact: remove cancel on SyncMetas errors (#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (#6017)

* fix duplicate metrics registration in redis client (#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Kartik-Garg added a commit to infracloudio/thanos that referenced this pull request Jan 18, 2023
@Kartik-Garg @clwluvw @kama910
Store: Make initial sync more robust
0b5a1d4 
Added re-try mechanism for store inital sync, where if the initial sync fails, it tries to do the initial sync again every 5 seconds for 15 seconds duration (total 3 re-tries for initial sync of store).

Signed-off-by: Kartik-Garg <[email protected]>

Store: Make initial sync more robust

Added re-try mechanism for store inital sync, where if the initial sync fails, it tries to do the initial sync again every 5 seconds for 15 seconds duration (total 3 re-tries for initial sync of store).

Signed-off-by: Kartik-Garg <[email protected]>

Merge release 0.30 into main (thanos-io#6041)

* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
sshantel pushed a commit to sshantel/thanos that referenced this pull request Jan 28, 2023
@GiedriusS @clwluvw
@kama910 @sshantel
Merge release 0.30 into main (thanos-io#6041)
668e143 
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
@GiedriusS @clwluvw @kama910
Merge release 0.30 into main (thanos-io#6041)
016bab3 
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
@GiedriusS @clwluvw @kama910
Merge release 0.30 into main (thanos-io#6041)
a7e9ea8 
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query: v0.29.0. Opentracing config create gopanic SIGSEGV
2 participants
@matej-g @yeya24