Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: add data touched by type to the dashboard #5838

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Store: add data touched by type to the dashboard #5838

merged 4 commits into from
Nov 25, 2022

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Oct 28, 2022 •
edited
Loading

Signed-off-by: Douglas Camata [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Adds a data touched by type widget to the Thanos Store dashboard.
  • Adds the data_type dimensions to the data touched/fetched widgets to provide deeper insights.

Depends on #5819.

Verification

Tested queries in a local Grafana instance.

@douglascamata douglascamata marked this pull request as ready for review October 28, 2022 15:49
@douglascamata douglascamata marked this pull request as draft October 28, 2022 15:49
@douglascamata douglascamata marked this pull request as ready for review October 28, 2022 15:51
saswatamcode
saswatamcode approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

philipgough
philipgough approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

GiedriusS
GiedriusS approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 thanks!

@GiedriusS GiedriusS merged commit 46873aa into thanos-io:main Nov 25, 2022
@douglascamata douglascamata mentioned this pull request Jan 11, 2023
Merged
douglascamata added a commit to rhobs/configuration that referenced this pull request Jan 11, 2023
@douglascamata
Upgrade Thanos' mixins to the latest version (#385)
615e5af 
Signed-off-by: Douglas Camata <[email protected]>

This should include the following PRs to improve the Store dashboard, with the ultimate goal in helping out deciding values for its limits:

* thanos-io/thanos#5989
* thanos-io/thanos#5838
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
@douglascamata
Store: add data touched by type to the dashboard (thanos-io#5838)
fa6db0a 
* Store: add data touched by type to the dashboard

Signed-off-by: Douglas Camata <[email protected]>

* Fix captions for data fetched and touched widgets

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Douglas Camata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@philipgough philipgough philipgough approved these changes

@GiedriusS GiedriusS GiedriusS approved these changes

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@douglascamata @fpetkovski @GiedriusS @philipgough @saswatamcode