Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive: Add experimental snapshot on shutdown #5836

Merged
merged 3 commits into from
Oct 30, 2022

Conversation

matej-g
Copy link
Collaborator

@matej-g matej-g commented Oct 28, 2022

Signed-off-by: Matej Gera [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Part of #5569.

Adds experimental feature from upstream Prometheus to enable snapshot on shutdown feature for TSDBs, which is intended to speed up the receiver restarts. For more https://ganeshvernekar.com/blog/prometheus-tsdb-snapshot-on-shutdown/.

Verification

/

Signed-off-by: Matej Gera <[email protected]>
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit 0e0f4fb into thanos-io:main Oct 30, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
* Add experimental snapshot on shutdown to receive

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants