Compact: Enable metadata cache #5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Wiedler <[email protected]>
igorwwwwwwwwwwwwwwwwwwww
force-pushed
the
compact-enable-metadata-cache
branch
from
cb902f1
to
192fc46
Compare
|
I wasn't sure if there's some consistency reasons for disabling this cache. But given how frequently we sync in the compactor, I think it makes sense to use the cache if possible. |
fpetkovski
approved these changes
Oct 7, 2022
matej-g
approved these changes
Oct 7, 2022
utukJ
pushed a commit
to utukJ/thanos
that referenced
this pull request
Oct 13, 2022
Signed-off-by: Igor Wiedler <[email protected]> Signed-off-by: Igor Wiedler <[email protected]> Signed-off-by: utukj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
data-dir/meta-syncerVerification
TBD.