-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Migrate tutorials to Killercoda #5745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
douglascamata
previously approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌔
GiedriusS
reviewed
Sep 30, 2022
GiedriusS
previously approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion
Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Matej Gera <[email protected]>
matej-g
dismissed stale reviews from GiedriusS and douglascamata
via
September 30, 2022 14:16
adf5dc7
Skipping tests since it's just doc update. |
utukJ
pushed a commit
to utukJ/thanos
that referenced
this pull request
Oct 13, 2022
* Update MD docs with links to Killercoda Signed-off-by: Matej Gera <[email protected]> * Update tutorials readme, point to tutorials repo Signed-off-by: Matej Gera <[email protected]> * Remove old Katacoda scenario definitions Signed-off-by: Matej Gera <[email protected]> * Adjust release process doc Signed-off-by: Matej Gera <[email protected]> * Update docs/getting-started.md Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: utukj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #5385.
After we had to temporarily remove Katacoda tutorials in #5454, we can now add them back after we have successfully migrated to Killercoda 🎉
Tutorials are available under https://killercoda.com/thanos
The tutorial definitions have now been moved to https://github.com/thanos-io/tutorials.
Verification
We manually went through the tutorials.