Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Frontend: Split interval middleware sends query when start equals false #5714

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Query Frontend: Split interval middleware sends query when start equals false #5714

merged 1 commit into from
Sep 26, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 23, 2022

Signed-off-by: Ben Ye [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Same as cortexproject/cortex#4877.

Query frontend should send the request to downstream when start == end.

Verification

matej-g
matej-g approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@matej-g matej-g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@matej-g matej-g merged commit 1c18ef4 into thanos-io:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeya24 @fpetkovski @matej-g