query: add --grpc-compression for enabling compression #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
add_grpc_compression_query
branch
from
87df299 to
e74fa3a
Compare
fpetkovski
previously approved these changes
Aug 29, 2022
|
Network usage throughput has dropped by about 2x - from ~50MiB/s to ~25MiB/s. But my servers are not using much, to begin with, due to client-side caching in Rueidis. 😄 99p now sometimes even drops to 2-3 seconds whereas before it never dipped below 5s. |
GiedriusS
force-pushed
the
add_grpc_compression_query
branch
from
e74fa3a to
aff3dcb
Compare
Add a new `--grpc-compression` option that enables gRPC compression. Snappy works well - I've observed barely any increase in CPU/RAM usage and the network throughput dropped. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_compression_query
branch
from
aff3dcb to
b36ebcd
Compare
|
This is a nice improvement! Can you update the changelog as well? Thanks! |
…query Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
|
Added, PTAL @yeya24 |
prajain12
pushed a commit
to prajain12/thanos
that referenced
this pull request
Sep 6, 2022
Signed-off-by: Prakul Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
--grpc-compressionoption that enables gRPC compression.Snappy works well - I've observed barely any increase in CPU/RAM usage
and the network throughput dropped.
I have also tried zstd with default settings but it increased the
99p quite a bit. Perhaps we could investigate zstd more in the future.