Proxy Store should not lock when all clients error. #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add this item to CHANGELOG.md? |
kdima
approved these changes
Oct 10, 2018
|
Updated |
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are calling many stores we need to ensure that if they all (more than 10) return an error we do not halt the as we cannot add more the the respCh in doing so we are eating into the number of queries we are allowing Thanos.
Changes
respChshould be one more than the number of stores we have ... this is so we can push all error responses to the channel and also the final error if the series has no results.Verification
Added a test.