-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compact.md #5620
Update compact.md #5620
Conversation
can someone tell why documentation check failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! It's nice to get some clean up in the docs! I added few smaller suggestions 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
How do you fixed doc/Documentation test in PR ? My doc check also getting failed in PR. |
is it done or more work to be done on this?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Matej Gera <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Update compact.md Signed-off-by: Tushar Dahiya <[email protected]> * Apply suggestions from code review Co-authored-by: Matej Gera <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]> * Apply suggestions from code review Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]> * Apply suggestions from code review Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]> Signed-off-by: Tushar Dahiya <[email protected]> Co-authored-by: Matej Gera <[email protected]> Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Prakul Jain <[email protected]>
Signed-off-by: Tushar Dahiya [email protected]
fixed 🚩 Grammatical Error
Changes
Verification