Filter external labels from matchers on LabelValues/LabelNames #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oron Sharabi <[email protected]>
oronsh
force-pushed
the
filter-ext-labels
branch
from
dea5e79 to
02dfb61
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Oron Sharabi <[email protected]>
oronsh
force-pushed
the
filter-ext-labels
branch
from
eaeb528 to
893ba45
Compare
|
Fixes issue #5577 |
Signed-off-by: Oron Sharabi <[email protected]>
bwplotka
previously approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Great job and idea, thanks! 💪🏽
Do you mind re-shaping comments to be compatible with our Go guide?
pkg/store/bucket.go
Outdated
| @@ -1254,6 +1254,11 @@ func (s *BucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesReq | |||
| if len(reqBlockMatchers) > 0 && !b.matchRelabelLabels(reqBlockMatchers) { | |||
| continue | |||
| } | |||
| // filter ext labels | |||
There was a problem hiding this comment.
Can we have comments as full sentences?
pkg/store/bucket.go
Outdated
| @@ -1341,6 +1346,25 @@ func (s *BucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesReq | |||
| }, nil | |||
| } | |||
|
|
|||
| func (b *bucketBlock) FilterExtLabelsMatchers(matchers []*labels.Matcher) ([]*labels.Matcher, bool) { | |||
| // we filter external labels from matchers | |||
Signed-off-by: Oron Sharabi <[email protected]>
|
Thanks for the review @bwplotka ! fixed comments :) |
|
Thanks! |
GiedriusS
pushed a commit
to vinted/thanos
that referenced
this pull request
Aug 25, 2022
…s-io#5596) * Filter external labels from matchers on LabelValues/LabelNames Signed-off-by: Oron Sharabi <[email protected]> * Fix linting Signed-off-by: Oron Sharabi <[email protected]> * Fix linter Signed-off-by: Oron Sharabi <[email protected]> * Fix comments to be full Sentences Signed-off-by: Oron Sharabi <[email protected]> Signed-off-by: Oron Sharabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Filter external labels from matchers in
LabelValuesandLabelNamesrpcs.We noticed super high memory spikes in
storegatewayfor the label apis and noticed that if there're matchers store will try to fetch series for postings.When using
prom-label-proxyto enforcetenant_idlabel for example, it's propagating to matchers and so going to slow path, sincetenant_idor any other external label is only presented onmeta.json, all series would have to be fetched resulting in huge memory spikes (~50Gb and more).By filtering external labels from matchers we ensure this won't happen and also filtering the blocks that have those external labels but with different values.
Tested locally and it solved the issue.
Verification