query: set default times for query_exemplars API #5014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Grave [email protected]
Changes
Fixes #5011
I replaced calls to
cortexutil.ParseTime
withparseTimeParam
inNewExemplarsHandler
since the later allows default times to be set.I removed the
cortexutil
since the above change made it redundant.The impact is that this behaviour mirrors Prometheus’ behaviour and allows exemplars to be displayed in Grafana.
Verification
I effected some functional tests. I ran my own container (paulgrave/thanos:0.24.1) on my cluster and validated that exemplars are now displayed in Grafana.
Executed
curl -v -d query=test http://localhost:10902/api/v1/query_exemplars
to validate that a) API doesn’t error b) returns a 200 instead of a 400.Executed
curl -v -d query='my_requests_total{app="prom-py"}' -d start=1640770731.689 -d end=(date +%s) http://localhost:10902/api/v1/query_exemplars | jq
to validate that exemplars are indeed returned like before.Thanos is running as expected on my local cluster.
Unfortunately
make lint
andmake test
are broken on my M1 Mac.