remove old promql editor #4864
Merged
remove old promql editor #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexucis
force-pushed
the
feature/remove-old-promql-editor
branch
2 times, most recently
from
ec8f8f2 to
a181e53
Compare
|
@onprem ;) |
onprem
previously approved these changes
Nov 14, 2021
|
|
||
| describe('ExpressionInput', () => { | ||
| const metricNames = ['instance:node_cpu_utilisation:rate1m', 'node_cpu_guest_seconds_total', 'node_cpu_seconds_total']; | ||
| describe('CMExpressionInput', () => { |
There was a problem hiding this comment.
Just a nit, for staying consistent with component name.
Suggested change
| describe('CMExpressionInput', () => { | |
| describe('ExpressionInput', () => { |
CHANGELOG.md
Outdated
| @@ -36,6 +36,10 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| - [#4792](https://github.com/thanos-io/thanos/pull/4792) Store: Fix data race in BucketedBytes pool. | |||
| - [#4769](https://github.com/thanos-io/thanos/pull/4769) Query-frontend+api: add "X-Request-ID" field and other fields to start call log. | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - [#4864](https://github.com/thanos-io/thanos/pull/4864) Remove the old PromQL editor | |||
There was a problem hiding this comment.
Suggested change
| - [#4864](https://github.com/thanos-io/thanos/pull/4864) Remove the old PromQL editor | |
| - [#4864](https://github.com/thanos-io/thanos/pull/4864) UI: Remove the old PromQL editor |
It'd be nice if we can prefix this with UI: . More context for people reading changelog.
Signed-off-by: Augustin Husson <[email protected]>
Nexucis
force-pushed
the
feature/remove-old-promql-editor
branch
from
a181e53 to
8264350
Compare
|
thanks for your review @onprem. I updated the PR, it should be good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the old promql editor in Prometheus (prometheus/prometheus#9452). I think it makes it is removed here as well :).
Signed-off-by: Augustin Husson [email protected]