Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor: add block-viewer.global.sync-block-timeout for sync block metas #4764

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

ianwoolf
Copy link
Contributor

@ianwoolf ianwoolf commented Oct 10, 2021

fix #4763

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

add flag block-viewer.global.sync-block-timeout to set the timeout of sync block metas.

Signed-off-by: ianwoolf [email protected]

@ianwoolf ianwoolf force-pushed the pr-add-param-for-fetch branch 2 times, most recently from cb6f0ce to 6aa085e Compare October 10, 2021 09:15
@ianwoolf ianwoolf changed the title add block-viewer.global.sync-block-timeout for sync block metas Compactor: add block-viewer.global.sync-block-timeout for sync block metas Oct 11, 2021
@ianwoolf ianwoolf force-pushed the pr-add-param-for-fetch branch 3 times, most recently from 2624f42 to d54badb Compare October 11, 2021 06:54
@ianwoolf
Copy link
Contributor Author

ianwoolf commented Oct 11, 2021

image

doesn't seem to be related to this pr. i trigger again and pass test.

@ianwoolf ianwoolf force-pushed the pr-add-param-for-fetch branch from 1a10a23 to aea657e Compare October 11, 2021 07:40
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A separate flag for timeout makes sense to me.

@GiedriusS GiedriusS merged commit fa476b5 into thanos-io:main Oct 14, 2021
@ianwoolf ianwoolf deleted the pr-add-param-for-fetch branch October 14, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compactor: add sync block metas timeout for block-viewer
3 participants