-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Store] Metric to capture timestamp of the last loaded block #4710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine 👍 But maybe could you give us a bit more context why this is required? What is the use case for it etc.?
Good point! Updated the PR description. |
In the Thanos UI stores tab, each store already reports the In an ideal world, each component that exposes the Store API would expose this information. Users deploy Thanos in all kinds of configuration, it would be useful to have this information available even if they are deploying components other than Store. |
Signed-off-by: SriKrishna Paparaju <[email protected]>
017ef78
to
daafd16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: SriKrishna Paparaju <[email protected]>
Signed-off-by: SriKrishna Paparaju [email protected]
Currently Thanos does not have visibility into
when a block is loaded
. Lack of this visibility can be a challenge either with chosen downsampling options (or any other reason) might cause data loss and there is no way to know the extent of the data loss. This PR adds metric to capture timestamp of the last loaded block.Changes
Verification
Added unit test logic, tested thru 'TestBucketStore_e2e() of github.com/thanos-io/thanos/pkg/store'