block (UI and API): Add mark deletion and no compaction UI #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
previously approved these changes
Sep 1, 2021
pkg/api/blocks/v1.go
Outdated
| } | ||
|
|
||
| switch actionParam { | ||
| case "DELETION": |
There was a problem hiding this comment.
Can move this to Go content so we don't make typo/mistake here?
|
Do you mind rebasing to fix bindata? |
yeya24
reviewed
Sep 2, 2021
|
What about having adding this to the latest release? @bwplotka |
adzshaf
force-pushed
the
add-post-marking
branch
from
b637cb3
to
ecf1ec1
Compare
yeya24
reviewed
Sep 17, 2021
onprem
previously approved these changes
Nov 2, 2021
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Signed-off-by: Shafiya Adzhani <[email protected]>
Update pkg/api/blocks/v1.go Co-authored-by: Prem Kumar <[email protected]> Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
add-post-marking
branch
from
5976c61
to
5611c69
Compare
|
Sorry for my poor git skill. I rebased the code and all previous commits are also signed off by me, too. Hope this is okay @adzshaf. I fixed the bindata and tested it working locally. Overall this looks good, but there is some work to fix: In the dark mode, I expect the button to have a lighter color. Also after I click |
yeya24
approved these changes
Nov 6, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of LFX mentorship project (issue: #3112). We want to add mark deletion and no compaction button in block details UI.
Changes
/block/markendpoint for trigger marking block APIVerification
Tested in local using
make quickstartExample of mark deletion:
Result of mark deletion:
Example of mark no compaction:
Result of mark no compaction:
cc: @squat @onprem